feat(sortKey): add sortKey to contract response #53

dtfiedler · 2023-11-10T18:47:39Z

This allows those evaluating contract state using warp to use this service to bootstrap state from our cache

Example:

const contractTxId =  'bLAgYxAdX2Ry-nt6aH2ixgvJXbpsEYm28NgJgyqfs-U';

// get contract manifest
const { evaluationOptions = {} } = await getContractManifest({
  contractTxId,
});

// Read the ArNS Registry Contract
const contract = await warp
  .contract(contractTxId)
  .setEvaluationOptions(evaluationOptions)
  .syncState(`http://localhost:3000/v1/contract/${contractTxId}`);

This allows those evaluating contract state using warp to use this service to bootstrap state from our cache

arielmelendez · 2023-11-10T19:08:13Z

src/types.ts

@@ -69,7 +69,8 @@ export type ContractReservedResponse = ContractBaseResponse & {
 // Warp types

 export type EvaluatedContractState = EvalStateResult<any> & {
-  evaluationOptions?: Partial<EvaluationOptions>;
+  evaluationOptions: Partial<EvaluationOptions>;


Did we intend to lose the optionality of this in the interface?

yep - we will always return it

arielmelendez · 2023-11-10T19:08:42Z

commitlint.config.js

@@ -19,4 +19,8 @@
 module.exports = {
  extends: ['@commitlint/config-conventional'],
  ignores: [(message) => message.includes('[skip ci]')],
+  rules: {


Intended change?

yes - it was preventing good commit messages that @djwhitt has pioneered

feat(sortKey): add sortKey to contract payload

1a5e2b1

This allows those evaluating contract state using warp to use this service to bootstrap state from our cache

dtfiedler requested a review from a team as a code owner November 10, 2023 18:47

dtfiedler changed the title ~~feat(sortKey): add sortKey to contract payload~~ feat(sortKey): add sortKey to contract response Nov 10, 2023

arielmelendez reviewed Nov 10, 2023

View reviewed changes

arielmelendez approved these changes Nov 10, 2023

View reviewed changes

dtfiedler merged commit a934f6c into main Nov 10, 2023
6 checks passed

dtfiedler deleted the PE-5003-add-sort-key branch November 10, 2023 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sortKey): add sortKey to contract response #53

feat(sortKey): add sortKey to contract response #53

dtfiedler commented Nov 10, 2023 •

edited

Loading

arielmelendez Nov 10, 2023

dtfiedler Nov 10, 2023

arielmelendez Nov 10, 2023

dtfiedler Nov 10, 2023

feat(sortKey): add sortKey to contract response #53

feat(sortKey): add sortKey to contract response #53

Conversation

dtfiedler commented Nov 10, 2023 • edited Loading

arielmelendez Nov 10, 2023

Choose a reason for hiding this comment

dtfiedler Nov 10, 2023

Choose a reason for hiding this comment

arielmelendez Nov 10, 2023

Choose a reason for hiding this comment

dtfiedler Nov 10, 2023

Choose a reason for hiding this comment

dtfiedler commented Nov 10, 2023 •

edited

Loading